Adding support for network-policies for self-agent and control-plane in helmchart#242
Open
Jonsy13 wants to merge 2 commits intolitmuschaos:masterfrom
Open
Adding support for network-policies for self-agent and control-plane in helmchart#242Jonsy13 wants to merge 2 commits intolitmuschaos:masterfrom
Jonsy13 wants to merge 2 commits intolitmuschaos:masterfrom
Conversation
Signed-off-by: Vedant Shrotria <vedant.shrotria@harness.io>
Signed-off-by: Vedant Shrotria <vedant.shrotria@harness.io>
Jasstkn
requested changes
Jun 22, 2022
Member
Jasstkn
left a comment
Jasstkn
left a comment
There was a problem hiding this comment.
Hey.
Seems good for me but you must bump chart version and perform docs update. I would also suggest to make some note in the values.yaml that those policies will be effective only if the CNI in the cluster supports it.
Member
|
@Jonsy13 hey. will you continue working on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]